E2E: Invent support for E2E Profile 05. #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgpires
suggested changes
Dec 18, 2023
| struct profile_config { | ||
| profile_config() = delete; | ||
|
|
||
| profile_config(uint32_t _data_id, size_t _offset, |
There was a problem hiding this comment.
Profile 05 does not require _min_data_length nor _max_data_length. Instead, it uses a fixed data length. The necessary parameters can be found here
|
|
||
| void write_8(e2e_buffer &_buffer, uint8_t _data, size_t _index); | ||
| void write_16(e2e_buffer &_buffer, uint16_t _data, size_t _index); | ||
| void write_32(e2e_buffer &_buffer, uint32_t _data, size_t _index); |
There was a problem hiding this comment.
This method is not used anywhere, it can be removed
| " (" << offset << ")"; | ||
| offset /= 8; | ||
|
|
||
| size_t min_data_length = read_value_from_config<size_t>(_config, |
There was a problem hiding this comment.
min_data_length and max_data_length are not parameters of profile 05, instead use just dataLength
| } | ||
|
|
||
| bool | ||
| profile_05_checker::verify_input(const e2e_buffer &_buffer) const { |
There was a problem hiding this comment.
The verify_input method should be checking the fixed dataLength
| } | ||
|
|
||
| bool | ||
| protector::verify_inputs(e2e_buffer &_buffer) { |
There was a problem hiding this comment.
The verify_input method should be checking the fixed dataLength
|
I added the requested changes. Please check and let me know if anything else needs to be fixed. Thanks. |
sgpires
approved these changes
Dec 19, 2023
goncaloalmeida
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested under 1 I split the P05 from the PR and add the changes here to a new PR.
This PR adds support for the E2E Profile 05, that we added and tested in our project.
Please check to merge the changes or request changes if needed. Thanks.