Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CMake #9

Open
wants to merge 9 commits into
base: rawhash2_tflite
Choose a base branch
from
Open

Improve CMake #9

wants to merge 9 commits into from

Conversation

adamant-pwn
Copy link
Collaborator

Pull request for fixes for #7.

@adamant-pwn
Copy link
Collaborator Author

adamant-pwn commented Jul 24, 2024

Since the workflow is currently not in the default branch, use_cache=false can only be used from GitHub CLI:

gh workflow run "Docker Build and Test" --ref <branch> -f use_cache=false

Test workflow with skipped build caching is here.

Dockerfile Outdated Show resolved Hide resolved
add_executable(rawhash2 wrapper_example.cpp)
target_link_libraries(rawhash2 PRIVATE rawhash2_lib)
set_target_properties(rawhash2 PROPERTIES INSTALL_RPATH $ORIGIN/../lib)
install(TARGETS rawhash2 RUNTIME DESTINATION bin)
Copy link
Collaborator Author

@adamant-pwn adamant-pwn Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently make install would install the shared library and also an executable that links to it. Should we install an executable that doesn't link to the rawhash2 shared library as well? Also generally what's the reason to build both rawhash2_builtin (former rawhash2) and rawhash2 (former rawhash2_usinglib) targets?

Copy link
Collaborator

@maximilianmordig maximilianmordig Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can build a shared and static library. The python wrapper needs a shared library, if I remember well.
The important thing is that both the rawhash python wrapper and rawhash cli can be built at the same time, unlike previously.
I used rawhash_lib, so that it can be included as a library in both the cli and the python wrapper, but this is not necessary if the above goal is met.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should be able to build both currently. What I'm really asking is: During the install, should we install both the "standalone" client and the client that depends on the static library, or only one of them? If only one, which? Would it be okay to only install the client that depends on RawHash shared library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants