Fix/update pipelines #230
Draft
Fix/update pipelines #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for embeddingsclarinpl canceled.
|
ktagowski
force-pushed
the
fix/update-pipelines
branch
from
5c0bee2
to
b182ae7
Compare
ktagowski
force-pushed
the
fix/update-pipelines
branch
3 times, most recently
from
f5fcbd7
to
9572f26
Compare
ktagowski
force-pushed
the
fix/update-pipelines
branch
from
9572f26
to
6d18471
Compare
asawczyn
requested changes
Apr 20, 2022
Co-authored-by: Albert <34009816+asawczyn@users.noreply.github.com>
ktagowski
force-pushed
the
fix/update-pipelines
branch
from
bd58aa4
to
d902d26
Compare
AdrianSzymczak
requested changes
Apr 20, 2022
|
|
||
| def _get_transformations( | ||
| self, data_loader: FLAIR_DATALOADERS | ||
| ) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
|
|
||
| transformation = self._get_dataset_transformation(data_loader) | ||
| transformation: FLAIR_DATASET_TRANSFORMATIONS_TYPE = DummyTransformation() | ||
| if self.encode_labels: |
There was a problem hiding this comment.
consider early exit, without extra nested if?
if self.encode_labels and isinstance(data_loader, (ConllFlairCorpusDataLoader, PickleFlairCorpusDataLoader)):
raise ValueError(
"ClassEncodeColumnTransformation transformation is unavailable for Flair DataLoaders. "
"Set parameter encode_labels value to True"
)
transformation= transformation.then(
ClassEncodeColumnTransformation(column=self.target_column_name)
) if self.encode_labels else transformation
asawczyn
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.