Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

822 forman netcdf4 lock issue #828

Merged
merged 2 commits into from
Dec 19, 2018
Merged

822 forman netcdf4 lock issue #828

merged 2 commits into from
Dec 19, 2018

Conversation

forman
Copy link
Member

@forman forman commented Dec 19, 2018

I'm now using engine='h5netcdf' to store OPeNDAP results because the default engine='netcdf4'
causes crashes in file "netCDF4/_netCDF4.pyx" with currently used netcdf4-1.4.2 conda
package from conda-forge. This occurs whenever remote_dataset.to_netcdf() is called a
second time in the loop that iterates over all OPeNDAP urls found for a query.

Probably related to pydata/xarray#2560.
And probably fixes Cate issues #823, #822, #818, #816, #783.

@codecov-io
Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #828 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
- Coverage   76.75%   76.71%   -0.04%     
==========================================
  Files          82       82              
  Lines       12764    12756       -8     
==========================================
- Hits         9797     9786      -11     
- Misses       2967     2970       +3
Impacted Files Coverage Δ
cate/ds/esa_cci_odp.py 52.48% <100%> (+0.13%) ⬆️
cate/util/web/jsonrpcmonitor.py 92.45% <0%> (-5.67%) ⬇️
cate/util/process.py 90.15% <0%> (-0.76%) ⬇️
cate/ops/coregistration.py 98.27% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f7b43...2bcce65. Read the comment docs.

@forman
Copy link
Member Author

forman commented Dec 19, 2018

@papesci and @dzelge this PR is for your records. I'm merging now.

@forman forman closed this Dec 19, 2018
@forman forman reopened this Dec 19, 2018
@forman forman merged commit 3263246 into master Dec 19, 2018
@dzelge dzelge deleted the 822-forman-netcdf4_lock_issue branch December 6, 2019 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants