Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ssl verify (built on atop of 1135) #1142

Merged
merged 5 commits into from
Dec 1, 2023
Merged

support ssl verify (built on atop of 1135) #1142

merged 5 commits into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. feat!: Add ssl_verify field to client::http::Options. 

    Currently this option only works in the curl backend.
    @Alvenix @Byron
    Alvenix authored and Byron committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    dfec281 View commit details
    Browse the repository at this point in the history

  2. assure ssl_verify is enabled by default, and also affect host verif… 

    …ication.

The differentiation between peer and host is done (in `git`) here:

https://github.com/git/git/blob/cfb8a6e9a93adbe81efca66e6110c9b4d2e57169/http.c#L980-L987
    @Byron
    Byron committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ab6e89c View commit details
    Browse the repository at this point in the history

  3. feat: In gix read http.sslVerify config value and pass it to gix-tran… 

    …sport.
    @Alvenix @Byron
    Alvenix authored and Byron committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c6e83cf View commit details
    Browse the repository at this point in the history

  4. feat: Add config value gitoxide.http.sslNoVerify 

    This value can by overriden by GIT_SSL_NO_VERIFY env variable. We use
the value to override http.sslVerify when specifying ssl_verify in
transport Options.
    @Alvenix @Byron
    Alvenix authored and Byron committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    dd575cd View commit details
    Browse the repository at this point in the history

  5. refactor

    @Byron
    Byron committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ead00e9 View commit details
    Browse the repository at this point in the history