Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_dua interactive_ only looks good with dark-themed terminals #13

Closed
ghost opened this issue Jun 16, 2019 · 3 comments · Fixed by #25
Closed

_dua interactive_ only looks good with dark-themed terminals #13

ghost opened this issue Jun 16, 2019 · 3 comments · Fixed by #25
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jun 16, 2019

Compare the images

light
dark
@ghost ghost added bug Something isn't working help wanted Extra attention is needed labels Jun 16, 2019
@r-darwish
Copy link

I think that the easiest solution is not to use the white color at all, but instead maybe just use bold regular or some other color. exa, for example, prints directories in blue.

@DarrienG
Copy link

That's what I ended up doing, but I wish there were a more elegant solution.

@vks
Copy link
Contributor

vks commented Jul 24, 2019

The problem is this line, which sets the background to white for light-themed terminals, which is also chosen as a background color. Setting it to any other color fixes the readability issue. To not change the look on dark-themed terminals, the color has to be set to black, which looks bad on light-themed terminals. Unfortunately, it is not possible to detect the background color of the terminal.

I suggest review any use of Color::Reset and consider using tui::style::Modifier for highlighting the current line.

vks added a commit to vks/dua-cli that referenced this issue Jul 24, 2019
@vks
Fix color scheme for light terminals
977e69f 
This is done by making sure that we never have a background that is
black or white combined with a foreground that uses the terminal's
default and vice versa.

Because we cannot access the default terminal colors, we have to rely on
inverted colors and bold text for highlighting.

Also, the mark pane was improved to be more consistent with the entries
pane. Ideally, we would use the same color as in the entries pane, but
this is currently not possible, because the mark pane does not know
whether a path is a directory or not.

Fixes Byron#13.
@vks vks mentioned this issue Jul 24, 2019
Merged
@ghost ghost closed this as completed in #25 Jul 25, 2019
@smason smason mentioned this issue Jun 10, 2022
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix color scheme for light terminals vks/dua-cli
3 participants
@vks @r-darwish @DarrienG