Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic pwa setup #1

Merged
merged 16 commits into from
Oct 4, 2023
Merged

basic pwa setup #1

merged 16 commits into from
Oct 4, 2023

Conversation

technophile-04
Copy link
Member

Description

Basic PWA setup and update the README, lol I think the README is not that great but please feel free to suggest 🙌

Additional Information

Related Issues

Your ENS/address: shivbhonde.eth

@Pabl0cks
Copy link
Member

gj Shiv!! 🙌

I'm trying this out to add extra details to Readme with the stuff I find difficult to execute during the setup, and found myself in trouble while trying to run yarn vercel. I had to change the import from contract.ts to use this route to make it work:

import { Prettify } from "viem/types/utils";

Think is related with SE2 issue #419, because I found the same problem while trying to yarn vercel a fresh SE2. Here are the details (screenshots from my SE2 test but the errors were the same on this PR):

yarn vercel, throws an error while building. Those are details for the errors on Vercel console:

image

Error from bash console on Windows:

$ yarn vercel
Vercel CLI 28.15.1
? Set up and deploy “E:\GitHub\scaffold-eth-2\packages\nextjs”? [Y/n] y
? Set up and deploy “E:\GitHub\scaffold-eth-2\packages\nextjs”? [Y/n] y
Loading scopes…
? Which scope do you want to deploy to?
? Which scope do you want to deploy to? tokodev
Searching for existing projects…
? Link to existing project? [y/N] n
? Link to existing project? [y/N] n
? What’s your project’s name? (nextjs) se2-test-viem-folder
? What’s your project’s name? se2-test-viem-folder
Verifying project name…
? In which directory is your code located? ./
? In which directory is your code located? ./
Setting up project
Uploading [--------------------] (0.0B/80.4KB)
Uploading [======--------------] (24.2KB/80.4KB)
Uploading [=============-------] (55.4KB/80.4KB)
Uploading [=================---] (71.4KB/80.4KB)
Uploading [====================] (80.4KB/80.4KB)
Local settings detected in vercel.json:
Auto-detected Project Settings (Next.js):
- Build Command: next build
- Development Command: next dev --port $PORT
- Install Command: `yarn install`, `pnpm install`, `npm install`, or `bun install`
- Output Directory: Next.js default
? Want to modify these settings? [y/N] n
? Want to modify these settings? [y/N] n
Deploying tokodev/se2-test-viem-folder
Linked to tokodev/se2-test-viem-folder (created .vercel)
Inspect: https://vercel.com/tokodev/se2-test-viem-folder/8n1XJey375nRJ5T2jp9aHy4BPwbH [1s]
https://se2-test-viem-folder-a65w9fbhz-tokodev.vercel.appQueued
Building
Error: Unexpected error. Please try again later. ()

Adding some extra steps and info to install, formatting and re-wording some sections
@Pabl0cks
Copy link
Member

I've just added some additional info to the Readme, and re-worded / formatted some sections.

We'll have to add all the features explanations when we have them, and keep improving current content in further iterations 🙌

@carletex
Copy link
Contributor

Great work @technophile-04!! And thanks @Pabl0cks for the review.

I'll give it a go this week. Will also set up the auto-deployment in Vercel & set up a Firebase

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@carletex
Copy link
Contributor

carletex commented Sep 26, 2023

Hey all! left some review comments.

Also, following the instructions, I get this when clicking "allow notification" (after accepting it in my browser/installed pwa)

UPDATE: It's working now. The firestore rules just take a bit to propagate :)

image
image

Any ideas on what I might be doing wrong?

README.md Outdated Show resolved Hide resolved
@carletex
Copy link
Contributor

carletex commented Oct 4, 2023

I think this is ready for a first merge.

I'm gonna create a branch "deployed-demo", where I'll branch from main and will use a Sepolia Contract so it works... until we firgure out next steps. It'll be connected to the BG's Vercel (something like pwa-demo.buidlguidl.com)

Thanks @technophile-04 & @Pabl0cks !

@carletex carletex merged commit b17797c into main Oct 4, 2023
1 check passed
technophile-04 pushed a commit to technophile-04/PWA-base that referenced this pull request Dec 25, 2023
* BuidlGuidl#1 started creating BurnerConnector.  additionally edited some config

* BuidlGuidl#1 changing rainbow connectors.  extracted connectors to its own folder

* BuidlGuidl#1 burner wallet is working

* BuidlGuidl#1 preminimnarly autoconnect working.  added some temp files to help check.  added useBurnerSigner

* BuidlGuidl#1 Finished autoconnect and burner wallet

* BuidlGuidl#1 Finished autoconnect and burner wallet

* BuidlGuidl#1 Finished autoconnect and burner wallet

* BuidlGuidl#1 better comments

* BuidlGuidl#1 better comments

* BuidlGuidl#1 better comments and cleaned up structure

* BuidlGuidl#1 simplified options

* minor

* Remove unrelated/extra stuff

* Prettify with exiting rules

* We want prettier to fix errors with eol without causing errors.  warnings will cause prettier to autofix errors without unecessary issues.

* Revert "We want prettier to fix errors with eol without causing errors.  warnings will cause prettier to autofix errors without unecessary issues."

This reverts commit 1282c22614aeceab6dbe5e0b84841b9ec94e6bfa.

* BuidlGuidl#1 We want prettier to fix errors with eol without causing errors.  warnings will cause prettier to autofix errors without unecessary issues.

* We want vscode to have linting properlly work on all of the workspaces.  We also want it to exclude settings files so that search and files are easier to use.

* BuidlGuidl#1 fixed issue with eslint

* BuidlGuidl#1 fixed nots

* BuidlGuidl#1 remove unused variables

* BuidlGuidl#1 removed comments

* BuidlGuidl#1 fixes for bugs.  TODO: write is no longer working with burner, need to find out why signer doesn't work

* BuidlGuidl#1 pushed changes to get the signer to work properly

* BuidlGuidl#1 removed imports

* BuidlGuidl#1 changed how initial save of sk was happening

* updated git ignore

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants