Allow changing suffix FileDivede Class #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliboa/scenario/transform/file.py
Outdated
| @@ -422,13 +422,21 @@ def __init__(self): | |||
| super().__init__() | |||
| self._divide_rows = None | |||
| self._header = False | |||
| self._suffix_symbol = "." | |||
| self._suffix_number = 0 | |||
There was a problem hiding this comment.
パラメータを分けずに、書式化演算子などのフォーマットで指定できる方が汎用的かと思いました。
https://www.javadrive.jp/python/string/index23.html
デフォルトは'.%d'のイメージです。
There was a problem hiding this comment.
ご確認ありがとうございます
対応しました
yasuhiro-ohba
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
Allow changing suffix FileDivede Class
Points to Check
Test
Confirmed
Review Limit
I hope you'll see it soon.