Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output log for targetfile to CsvConvert class #305

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Conversation

nissy0409240
Copy link
Collaborator

Brief

Add output log for targetfile to CsvConvert class

Test

Not necessary

Review Limit

  • At the timing of your hand

@nissy0409240
Copy link
Collaborator Author

テスト落ちる件は最新版のpipenvのバグ起因です
pypa/pipenv#4865

Copy link
Contributor

@bp-gen-aihara bp-gen-aihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すいません。テスト落ちてる件は別で私も確認してみます。(確認する時には解決してるかもしれませんが)

@bo-naoki-okamoto
Copy link
Contributor

https://github.com/BrainPad/cliboa/blob/master/cliboa/scenario/transform/file.py#L138
issueタイトルと変わってしまいますがそのログはこちらに追加してもらうとio_filesを使った全ての箇所にログ出力が適用できるのでそのほうが望ましいかと思います

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@562396d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #305   +/-   ##
=========================================
  Coverage          ?   79.28%           
=========================================
  Files             ?       67           
  Lines             ?     3524           
  Branches          ?        0           
=========================================
  Hits              ?     2794           
  Misses            ?      730           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562396d...074072f. Read the comment docs.

@nissy0409240
Copy link
Collaborator Author

pipenvの修正が完了したためテストが通るようになりました

@yasuhiro-ohba yasuhiro-ohba merged commit 7a4c20d into master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add output log for targetfile to CsvConvert class
5 participants