Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

::embed author is in the footer instead of header. #11

Closed
s0lst1ce opened this issue May 1, 2019 · 1 comment
Closed

::embed author is in the footer instead of header. #11

s0lst1ce opened this issue May 1, 2019 · 1 comment
Assignees
@s0lst1ce
Labels
enhancement New feature or request
Milestone
v1

Comments

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented May 1, 2019

It would be more discord-like if the profile picture and the name of the embed's author was in the header instead of the footer.
@s0lst1ce s0lst1ce added the enhancement New feature or request label May 1, 2019
@s0lst1ce s0lst1ce self-assigned this May 1, 2019
@s0lst1ce s0lst1ce added this to the 0.1 milestone May 7, 2019
@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 8, 2019

I fulfilled the goal of the issue but I'm not satisfied with the result. Should I roll back the changes ?

@s0lst1ce s0lst1ce mentioned this issue May 8, 2019
Merged
s0lst1ce added a commit that referenced this issue May 8, 2019
@s0lst1ce
Merge pull request #9 from organic-bots/rewrite
46fae00 
This was a huge update I'm happy to pronounce complete ! Its main purpose has been achieved. We've been able to completely rewrite the entire code to make it more pythonic. This major rewrite now allows one to update the code without taking the bot offline by using the smart extension principle of the API. It is also much easier to find out bugs happening to the bot for a logging has been fully implemented to the bot and is easily extendable. This was one of the main purpose: make any future addition much easier to both build and implement. This should also allow a much wider range of contributors to help us in the development. This branch doesn't solve everything though, there are still efforts required toward documentation (see #1 ) and repository structure. But this is already an important milestone which paves the way to all future updates. Finally a number of issues have been fixed in this update as you can see in the following change log:

    admins can now update extensions on the fly with a new & safe ext suite of functions (#8 )
    added smart and extensive logging support (#13 )
    added a new suite of commands that allow smart task list management using labels directly from discord
    changed global settings from using unsafe names to unique snowflake discord IDs
    poll colors are now dynamic and change with every new reaction (#12 )
    changed the design of embeds to give more credits to authors (#11 )
    fixed a bug where users could have multiple opposite reactions to the same poll (#15 )
    gave more freedom to admins by letting them choose how much they wish to pardon a user (#16 )
    added the clear command that lets admins delete a set amount of messages to ease moderation (#17 )
    embeds now support images (#6 )
    users can now delete their own polls which prevents admin from having to clean mistakes themselves (#5 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0lst1ce s0lst1ce

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1
Development

No branches or pull requests
1 participant
@s0lst1ce