Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from isort to ruff/I #34

Merged
merged 4 commits into from
Oct 1, 2023
Merged

switch from isort to ruff/I #34

merged 4 commits into from
Oct 1, 2023

Conversation

Borda
Copy link
Owner

@Borda Borda commented Oct 1, 2023

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

simplify list of used tools

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Oct 1, 2023

Hello @Borda! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:80: E501 line too long (86 > 79 characters)
Line 21:80: E501 line too long (80 > 79 characters)

Comment last updated at 2023-10-01 12:31:39 UTC

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cc58214) 100.00% compared to head (c8d63ad) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          132       134    +2     
=========================================
+ Hits           132       134    +2     
Flag Coverage Δ
pytest 100.00% <100.00%> (ø)
python3.11 100.00% <100.00%> (ø)
python3.7 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/deprecate/__about__.py 100.00% <100.00%> (ø)
src/deprecate/deprecation.py 100.00% <100.00%> (ø)
src/deprecate/utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Borda Borda merged commit f51fd2c into main Oct 1, 2023
29 checks passed
@Borda Borda deleted the ruff/I branch October 1, 2023 12:35
Borda added a commit that referenced this pull request Oct 1, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants