Fix additional test suite issues #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tox recognizes "cpython" as a valid Python version identifier and rejects it in combination with "pyXY" identifiers: ``` ValueError: conflicting factors py310, cpython in py310-cpython-gevent ```
kurtmckee
force-pushed
the
fix-additional-test-suite-issues
branch
from
ffa2a9a
to
9afe685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two additional issues with the test suite:
rabbitmq_brokerfixture.These two issues are now addressed, and the test suite can be run more easily.
I recommend modifying CI to execute tox directly; this will more closely align local test suite execution and CI runs.