Eliminate a test ordering dependency #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `test_async_to_sync` runs immediately before `test_async_to_sync_no_thread`, the "no thread" test will fail to raise `RuntimeError` because the module-level `_event_loop_thread` variable will still be set (although it will be a mock, not a real thread).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
test_async_to_syncruns immediately beforetest_async_to_sync_no_thread, the "no thread" test will fail to raiseRuntimeErrorbecause the module-level_event_loop_threadvariable will still be set (although it will be a mock, not a real thread).This was discovered while trying to eliminate a different warning that only pops up if all of the asyncio tests are run; if only a handful of tests were selected, the warning disappears.
I strongly recommend adding pytest-randomly to the test suite's Python dependencies to help shake out test suite interdependencies such as what was found here.