Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow actors and messages to specify 0 backoff #438

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

FinnLidbetter
Copy link
Contributor

Fixes #388

Tests added to test_actors.py for small diff.

I have a separate branch on top of this locally that refactors all Retries tests from test_actors.py into a new test_retries.py module under tests/middleware. I can make a PR for that refactoring as well if desired.

@FinnLidbetter
Copy link
Contributor Author

Looks like CI / test on 3.5 (windows-2016) (pull_request) needs to be removed, since python min version was bumped to 3.6

@Bogdanp
Copy link
Owner

Bogdanp commented Nov 8, 2021

Looks good, thanks!

I have a separate branch on top of this locally that refactors all Retries tests from test_actors.py into a new test_retries.py module under tests/middleware. I can make a PR for that refactoring as well if desired.

That would be great.

@Bogdanp Bogdanp merged commit f86b551 into Bogdanp:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retries middleware ignores min_backoff=0 and max_backoff=0 values on messages
2 participants