Close an asyncio event loop in the test suite (#634)

Bogdanp · Jun 25, 2024 · 5bc361b · 5bc361b
1 parent 5ed539c
commit 5bc361b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/dramatiq/asyncio.py b/dramatiq/asyncio.py
@@ -112,6 +112,8 @@ def stop(self):
         if self.loop.is_running():
             self.logger.info("Stopping event loop...")
             self.loop.call_soon_threadsafe(self.loop.stop)
+            self.join()
+            self.loop.close()
 
     def run_coroutine(self, coro: Awaitable[R]) -> R:
         """Runs the given coroutine on the event loop.

diff --git a/tests/middleware/test_asyncio.py b/tests/middleware/test_asyncio.py
@@ -24,7 +24,6 @@ def started_thread():
     set_event_loop_thread(thread)
     yield thread
     thread.stop()
-    thread.join()
     set_event_loop_thread(None)