Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while trying to mount directory during the checkout step #479

Closed
frajasalo opened this issue Jun 30, 2022 · 1 comment · Fixed by #480
Closed

Error while trying to mount directory during the checkout step #479

frajasalo opened this issue Jun 30, 2022 · 1 comment · Fixed by #480
Labels
bug

Comments

@frajasalo
Copy link

We have a class that uses checkoutDep: True. When our project is build bob downloads this dependency from archive:

PACKAGE   skipped (already downloaded in work/ext/autoconf-archive/aarch64-linux-gnu/dist/2/workspace)

When the recipe that uses this class is checked out we get an error that bob can't mount the workspace. But bob wants to mount its build directory and not the dist:

src/namespace-sandbox/namespace-sandbox.c:547: cannot mount '/path/to/recipes/work/ext/autoconf-archive/aarch64-linux-gnu/build/2/workspace' on '/tmp/tmp0r3btqqp/bob/4d28a660b06a15c4db54ad27bcd838cbee9ace6f/workspace': No such file or directory
jkloetzke added a commit to jkloetzke/bob that referenced this issue Jun 30, 2022
@jkloetzke
spec: only add additional sandbox mounts from same package
240b1bf 
If a package is built in the sandbox it is defined that all previous
steps of the package are available in the sandbox. The code that added
these extra dependencies for the sandbox relied on the fact that
checkout steps have no dependencies. With the introduction of the
checkoutDep flag this is no longer the case. It is thus required to stop
iterating steps once we reached the checkout step.

Fixes BobBuildTool#479.
@jkloetzke jkloetzke mentioned this issue Jun 30, 2022
Merged
@jkloetzke jkloetzke added the bug label Jun 30, 2022
@jkloetzke
Copy link
Member

I think I found the culprit. Could you give it a thorough testing?

jkloetzke added a commit that referenced this issue Jul 14, 2022
@jkloetzke
spec: only add additional sandbox mounts from same package
b058ac5 
If a package is built in the sandbox it is defined that all previous
steps of the package are available in the sandbox. The code that added
these extra dependencies for the sandbox relied on the fact that
checkout steps have no dependencies. With the introduction of the
checkoutDep flag this is no longer the case. It is thus required to stop
iterating steps once we reached the checkout step.

Fixes #479.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spec: only add additional sandbox mounts from same package jkloetzke/bob
2 participants
@jkloetzke @frajasalo