Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten share URL #29

Closed
KyLeggiero opened this issue Dec 26, 2017 · 3 comments · Fixed by #40
Closed

Shorten share URL #29

KyLeggiero opened this issue Dec 26, 2017 · 3 comments · Fixed by #40
Assignees
@KyLeggiero
Labels
Design Related to the UI/UX of the product Janitorial Chores that must be done to keep the product and its codebase clean and up-to-date

Comments

@KyLeggiero
Copy link
Member

The current share URL is too long; we need to look into shortening it while still leaving it open to manipulation by external APIs. This might pair well with #25
@KyLeggiero KyLeggiero added Design Related to the UI/UX of the product Janitorial Chores that must be done to keep the product and its codebase clean and up-to-date labels Dec 26, 2017
@KyLeggiero KyLeggiero self-assigned this Dec 26, 2017
@KyLeggiero KyLeggiero mentioned this issue Dec 26, 2017
Merged
@KyLeggiero
Copy link
Member Author

KyLeggiero commented Dec 27, 2017 •
edited
Loading

Idea: Use Bit.ly or other shortening service's API

https://dev.bitly.com/get_started.html

@KyLeggiero
Copy link
Member Author

Because Bit.ly is rate-limited, we should have a way for the share URL to only be generated on-demand.

https://dev.bitly.com/rate_limiting.html

@KyLeggiero KyLeggiero mentioned this issue Mar 9, 2018
Merged
KyLeggiero added a commit that referenced this issue Mar 9, 2018
@KyLeggiero
Merge pull request #40 from BlueHuskyStudios/feature/RS-29
7876cc9 
#29 Used Goo.gl to shorten the sharing URL
@KyLeggiero
Copy link
Member Author

This was resolved with Goo.gl instead of Bit.ly

@KyLeggiero KyLeggiero mentioned this issue Apr 29, 2018
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KyLeggiero KyLeggiero

Labels
Design Related to the UI/UX of the product Janitorial Chores that must be done to keep the product and its codebase clean and up-to-date
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#29 Used Goo.gl to shorten the sharing URL BlueHuskyStudios/Rent-Split
1 participant
@KyLeggiero