Pass params by const ref

Blake-Madden · May 18, 2023 · 968afca · 968afca
1 parent 108e750
commit 968afca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/startpage.cpp b/startpage.cpp
@@ -14,7 +14,7 @@ wxDEFINE_EVENT(wxEVT_STARTPAGE_CLICKED, wxCommandEvent);
 wxStartPage::wxStartPage(wxWindow* parent, wxWindowID id /*= wxID_ANY*/,
                          const wxArrayString& mruFiles /*= wxArrayString{}*/,
                          const wxBitmapBundle& logo /*= wxBitmapBundle{}*/,
-                         const wxString productDescription /*= wxString{}*/)
+                         const wxString& productDescription /*= wxString{}*/)
         : wxWindow(parent, id, wxDefaultPosition, wxDefaultSize,
                    wxFULL_REPAINT_ON_RESIZE, L"wxStartPage"),
           m_logoFont(wxFontInfo(

diff --git a/startpage.h b/startpage.h
@@ -99,7 +99,7 @@ class wxStartPage final : public wxWindow
     explicit wxStartPage(wxWindow* parent, wxWindowID id = wxID_ANY,
         const wxArrayString& mruFiles = wxArrayString{},
         const wxBitmapBundle& logo = wxBitmapBundle{},
-        const wxString productDescription = wxString{});
+        const wxString& productDescription = wxString{});
     /// @private
     wxStartPage() = delete;
     /// @private
@@ -146,7 +146,7 @@ class wxStartPage final : public wxWindow
     /// @returns The ID assigned to the button. This should be used in your
     ///     @c wxEVT_STARTPAGE_CLICKED handler.
     /// @sa GetButtonID().
-    wxWindowID AddButton(const wxArtID artId, const wxString& label)
+    wxWindowID AddButton(const wxArtID& artId, const wxString& label)
         {
         wxVector<wxBitmap> bmps;
         bmps.push_back(