-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAQ] Adding, grid #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync from master
Update Sylius to 1.0.0 and PHP to 7.1+
[Page] Check if products exist
Added block fixtures
Update fork
Need more fixes with translated names
[Block][Page] Fix grid sorting
Update fork
Works, Last test fail
But need to check code null/not null last test fail
bitbager
reviewed
Nov 1, 2017
@@ -8,6 +8,9 @@ BitBag\CmsPlugin\Entity\FrequentlyAskedQuestion: | |||
generator: | |||
strategy: AUTO | |||
fields: | |||
code: | |||
type: string | |||
nullable: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code can not be null :)
bitbager
pushed a commit
to bitbager/SyliusCmsPlugin
that referenced
this pull request
Feb 7, 2018
Use Trusty on Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding - works but need to check code field (null/not null default value)