OP-326: New content elements #506
Conversation
jkindly
commented
Jul 8, 2024
jkindly
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | OP-326 |
| License | MIT |
jkindly
changed the base branch from
master
to
feature/OP-312-redesign-cms-plugin
| public function findByNamePart(string $phrase): array | ||
| { | ||
| return $this->createQueryBuilder('o') | ||
| ->andWhere('o.name LIKE :name') |
There was a problem hiding this comment.
Couldn't we really do this in another way? LIKE %% has incredible bad performance...
There was a problem hiding this comment.
I agree, but there is already exact the same method in block, collection and pages. I just copied this one to the media. I'm not sure what we can change here. I was looking for a solution and didn't find anything special, except Elasticsearch or something similar. Maybe you have some idea?
| @@ -131,6 +131,30 @@ public function iFillTheNameIfItIsEmpty(string $name): void | |||
| $this->resolveCurrentPage()->fillNameIfItIsEmpty($name); | |||
| } | |||
|
|
|||
| /** | |||
| * @When I click on Add button in Content elements section | |||
There was a problem hiding this comment.
Yes, because it is name of the section, not single content element, so I think it should be capitalized.
| { | ||
| Assert::isInstanceOf($this->getDriver(), ChromeDriver::class); | ||
|
|
||
| $addButton = $this->getElement('content_elements_add_button'); | ||
| $addButton->click(); | ||
|
|
||
| $addButton->waitFor(3, function (): bool { | ||
| return $this->hasElement('content_elements_textarea'); | ||
| $addButton->waitFor(2, function (): bool { |
There was a problem hiding this comment.
It's seconds. All behat tests are written like this, even in Sylius core. I changed all occurrences to lower ones.
