PHPspec tests to cover some of Entities #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbager
reviewed
Aug 23, 2017
src/spec/Entity/BlockSpec.php
Outdated
| const TYPE = 'Top Field'; | ||
| const CODE = 'xs'; | ||
|
|
||
|
|
| @@ -1,25 +1,29 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
Description and author information must not be removed.
| use PhpSpec\ObjectBehavior; | ||
| use Sylius\Component\Resource\Model\ResourceInterface; | ||
| use Sylius\Component\Core\Model\ImageInterface; | ||
|
|
| const METAKEYWORDS = 'php, js, jquery'; | ||
| const METADESCRIPTION = 'This is what You get.'; | ||
| const CONTENT = 'Some of the content.'; | ||
|
|
There was a problem hiding this comment.
Once again, one blank line between consts and function declaration :)
| use BitBag\CmsPlugin\Entity\PageInterface; | ||
| use PhpSpec\ObjectBehavior; | ||
| use Sylius\Component\Resource\Model\ResourceInterface; | ||
|
|
| use BitBag\CmsPlugin\Entity\ImageBlock; | ||
| use PhpSpec\ObjectBehavior; | ||
| use Prophecy\Argument; | ||
|
|
src/spec/Entity/PageSpec.php
Outdated
|
|
||
| $this->setMetaDescription(self::METADESCRIPTION); | ||
| $this->getMetaDescription()->shouldReturn('This is what You get.'); | ||
|
|
There was a problem hiding this comment.
We do not accept commented code in our projects. Please, remove it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.