Op 278 - Add sylius 1.13 support #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SzymonKostrubiec
commented
Jun 3, 2024
•
SzymonKostrubiec
commented
- Apply changes from community pull request
- Fixed a .gitignore file
- Added builds for nods 18.x
- Restore google chrome driver in behat tests
… behat configuration
marekrzytki
requested changes
Jun 4, 2024
tests/Application/config/sylius/1.12/packages/jms_serializer.yaml
Outdated
Show resolved
Hide resolved
marekrzytki
requested changes
Jun 4, 2024
| @@ -0,0 +1,124 @@ | |||
| security: | |||
There was a problem hiding this comment.
This file is not compatible with security changes from Sylius upgrade file: https://github.com/Sylius/Sylius/blob/1.14/UPGRADE-1.13.md -> point 11.
Also I think You are missing include in 1.13 bundles for Sylius\Abstraction\StateMachine\SyliusStateMachineAbstractionBundle::class => ['all' => true],
marekrzytki
approved these changes
Jun 4, 2024
|
@marekrzytki @SzymonKostrubiec thank you for not mentioning me in the Release note, like I already mentioned: you are not engaging comunity by replacing the original PR creator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.