-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Block][Page] Switch to strict types #24
Conversation
Sync with master dev
*/ | ||
public function setContent($content); | ||
public function setContent(?string $content): void; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ImageInterface|null
{ | ||
return $this->content; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function setContent($content) | ||
public function setContent(?string $content): void | ||
{ | ||
$this->content = $content; | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you switch @mixed to {@inheritdoc}?
|
||
/** | ||
* @return ImageInterface | ||
*/ | ||
public function getImage(); | ||
public function getImage(): ?ImageInterface; | ||
|
||
/** | ||
* @param ImageInterface $image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ImageInterface|null
src/Entity/Page.php
Outdated
{ | ||
return $this->getPageTranslation()->getName(); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function setName($name) | ||
public function setName(?string $name): void | ||
{ | ||
$this->getPageTranslation()->setName($name); | ||
} | ||
|
||
/** | ||
* @return PageTranslationInterface|TranslationInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PageTranslationInterface|TranslationInterface
or null 😄
Thank you, Paweł! 🍺 |
No description provided.