Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap support #41

Closed
stefandoorn opened this issue Oct 18, 2017 · 6 comments · Fixed by #152
Closed

Sitemap support #41

stefandoorn opened this issue Oct 18, 2017 · 6 comments · Fixed by #152
Labels

Comments

@stefandoorn
Copy link
Contributor

Sylius Sitemap Plugin exists: https://github.com/stefandoorn/sitemap-plugin. Would be great to have a provider to include the page URL's into it.

Some options:

  • Only provide a provider in this repo with tag sylius.sitemap_provider and add the sitemap plugin as a suggest to composer.json. And optionally put the activation behind a config setting.
  • Provide functionality in a separate repo that requires both this package and the sitemap package + add the provider

@bitbager What do you prefer?

@bitbager
Copy link
Member

Hmm, I think that generic sitemap provider functionality can be added to the plugin and an extra plugin for it would be too much. Would it be possible to write a sitemap processor and add the sitemap extension installation guide to the README file?

@stefandoorn
Copy link
Contributor Author

If we put it behind a config setting, then we can dynamically load the service definition that includes the sitemap provider (which gives the URL's to the sitemap plugin). In that case the plugin also doesn't crash if users do not load the sitemap plugin.

It would be weird to include it as requirement, as users then automatically get a sitemap also for products/taxons, etc. (not configurable yet). So it would be good to really activate it I think. WDYT about this?

@bitbager
Copy link
Member

Yeap, looks like it would require another plugin. But it should not be hard to develop.

@stefandoorn
Copy link
Contributor Author

Ok. I'll see if I can get it working inside the plugin first, else I'll go for a separate package.

@bitbager
Copy link
Member

Perfect! Let me know once you make some progress 🙂

bitbager pushed a commit to bitbager/SyliusCmsPlugin that referenced this issue Nov 5, 2017
@bitbager
Copy link
Member

@stefandoorn, any news? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants