-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sitemap support #41
Comments
Hmm, I think that generic sitemap provider functionality can be added to the plugin and an extra plugin for it would be too much. Would it be possible to write a sitemap processor and add the sitemap extension installation guide to the README file? |
If we put it behind a config setting, then we can dynamically load the service definition that includes the sitemap provider (which gives the URL's to the sitemap plugin). In that case the plugin also doesn't crash if users do not load the sitemap plugin. It would be weird to include it as requirement, as users then automatically get a sitemap also for products/taxons, etc. (not configurable yet). So it would be good to really activate it I think. WDYT about this? |
Yeap, looks like it would require another plugin. But it should not be hard to develop. |
Ok. I'll see if I can get it working inside the plugin first, else I'll go for a separate package. |
Perfect! Let me know once you make some progress 🙂 |
Remove `app/autoload.php`
@stefandoorn, any news? 🙂 |
Sylius Sitemap Plugin exists: https://github.com/stefandoorn/sitemap-plugin. Would be great to have a provider to include the page URL's into it.
Some options:
sylius.sitemap_provider
and add the sitemap plugin as a suggest to composer.json. And optionally put the activation behind a config setting.@bitbager What do you prefer?
The text was updated successfully, but these errors were encountered: