[Spotless] Applying Google Code Format for sql files #11 #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Codecov Report
@@ Coverage Diff @@
## integ/sl_GoogleJavaFormat11 #330 +/- ##
=================================================================
- Coverage 97.51% 97.51% -0.01%
- Complexity 4657 4658 +1
=================================================================
Files 408 408
Lines 11933 11913 -20
Branches 829 828 -1
=================================================================
- Hits 11637 11617 -20
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yury-Fridlyand
approved these changes
Aug 5, 2023
acarbonetto
approved these changes
Aug 14, 2023
| @@ -27,6 +26,8 @@ | |||
| import org.opensearch.sql.sql.parser.context.QuerySpecification; | |||
|
|
|||
| /** | |||
| * | |||
| return args; | ||
| } | ||
|
|
||
| /** | ||
| * |
| @@ -74,31 +73,36 @@ public class QuerySpecification { | |||
| private final Set<UnresolvedExpression> aggregators = new LinkedHashSet<>(); | |||
|
|
|||
| /** | |||
| * | |||
matthewryanwells
approved these changes
Aug 15, 2023
Yury-Fridlyand
approved these changes
Aug 15, 2023
MitchellGale
merged commit 74d950c
into
integ/sl_GoogleJavaFormat11
16 of 20 checks passed
MitchellGale
added a commit
that referenced
this pull request
Aug 16, 2023
…project#1968) * [Spotless] Applying Google Code Format for sql files #11 (#330) * Spotless apply, ignore checkstyle, manual java doc fixes. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply suggestions from code review Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 22, 2023
…project#1968) * [Spotless] Applying Google Code Format for sql files #11 (#330) * Spotless apply, ignore checkstyle, manual java doc fixes. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply suggestions from code review Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies spotless for SQL directory in project. Sets checkstyle to not fail on failure for sql directory.
Issues Resolved
opensearch-project#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.