Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Applying Google Code Format for integ-tests #9 #328

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

MitchellGale
Copy link

Description

Spotless apply on integ-test (part 2 of 4 integ-test integration).

Issues Resolved

opensearch-project#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #328 (072b594) into integ/sl_GoogleJavaFormat9 (245c4f8) will not change coverage.
The diff coverage is n/a.

❗ Current head 072b594 differs from pull request most recent head 739551c. Consider uploading reports for the commit 739551c to get more accurate results

@@                      Coverage Diff                      @@
##             integ/sl_GoogleJavaFormat9     #328   +/-   ##
=============================================================
  Coverage                         97.51%   97.51%           
  Complexity                         4657     4657           
=============================================================
  Files                               408      408           
  Lines                             11933    11933           
  Branches                            829      829           
=============================================================
  Hits                              11637    11637           
  Misses                              289      289           
  Partials                              7        7           
Flag Coverage Δ
sql-engine 97.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Yury-Fridlyand
Copy link

There are changes for :core...

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

rebase changes.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Addressed PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@MitchellGale MitchellGale merged commit 87d1fd6 into integ/sl_GoogleJavaFormat9 Aug 15, 2023
16 of 20 checks passed
MitchellGale added a commit that referenced this pull request Aug 16, 2023
…-project#1966)

* Add spotless apply 60 files. (#328)

rebase changes.



Addressed PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
MitchellGale added a commit that referenced this pull request Aug 22, 2023
…-project#1966)

* Add spotless apply 60 files. (#328)

rebase changes.

Addressed PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/legacy/QueryIT.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants