[Spotless] Applying Google Code Format for core/src/main files #2 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
MitchellGale
force-pushed
the
integ/sl_GoogleJavaFormat2
branch
from
ead2e07
to
d00dc4d
Compare
Codecov Report
@@ Coverage Diff @@
## integ/sl_GoogleJavaFormat2 #321 +/- ##
================================================================
+ Coverage 97.42% 97.50% +0.08%
- Complexity 4647 4659 +12
================================================================
Files 408 408
Lines 11526 11912 +386
Branches 839 835 -4
================================================================
+ Hits 11229 11615 +386
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
acarbonetto
reviewed
Aug 3, 2023
| public interface ExecutionEngine { | ||
|
|
||
| /** | ||
| * Execute physical plan and call back response listener. | ||
| * Todo. deprecated this interface after finalize {@link ExecutionContext}. | ||
| * Execute physical plan and call back response listener. Todo. deprecated this interface after |
There was a problem hiding this comment.
@Yury-Fridlyand was this one of your comments? Do we need to address this?
acarbonetto
reviewed
Aug 3, 2023
| * Execute the {@link UnresolvedPlan}, using {@link ResponseListener} to get response. | ||
| * Todo. deprecated this interface after finalize {@link PlanContext}. | ||
| * Execute the {@link UnresolvedPlan}, using {@link ResponseListener} to get response. Todo. | ||
| * deprecated this interface after finalize {@link PlanContext}. |
acarbonetto
approved these changes
Aug 3, 2023
MitchellGale
merged commit ad948b8
into
integ/sl_GoogleJavaFormat2
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/exceptioncore/src/main/java/org/opensearch/sql/executorcore/src/main/java/org/opensearch/sql/expressioncore/src/main/java/org/opensearch/sql/monitorIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.