[Spotless] Applying Google Code Format for core/src/main files #3 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchellGale
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## integ/sl_GoogleJavaFormat3 #314 +/- ##
================================================================
- Coverage 97.42% 97.42% -0.01%
Complexity 4647 4647
================================================================
Files 408 408
Lines 11526 11522 -4
Branches 839 837 -2
================================================================
- Hits 11229 11225 -4
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Checkstyle fails for some of the changes. |
Yeah, sadly I think I'll have to disable checkstyle. I'm looking into making Spotless have the same rules as checkstyles to see if that works. |
MitchellGale
force-pushed
the
dev/sl_GoogleJavaFormat3
branch
from
8bb4117
to
335e1a4
Compare
acarbonetto
approved these changes
Jul 31, 2023
| * "out of nothing" which is corresponding with VALUES clause in SQL. | ||
| * Mostly all rows must have the same number of literals and each column should | ||
| * have same type or can be converted implicitly. | ||
| * In particular, typical use cases include: |
There was a problem hiding this comment.
can we ignore spotless here?
or add list tags...
| * 1> Optimize the current node with all the rules. | ||
| * 2> Optimize the all the child nodes with all the rules. | ||
| * 3) In case the child node could change, Optimize the current node again. | ||
| * {@link LogicalPlan} Optimizer. The Optimizer will run in the TopDown manner. 1> Optimize the |
There was a problem hiding this comment.
can we ignore spotless here or add list tags?
…ensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
… fixes files. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
…ava OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
force-pushed
the
dev/sl_GoogleJavaFormat3
branch
from
2cf21ec
to
a2a633a
Compare
MitchellGale
changed the base branch from
integ/sl_GoogleJavaFormat3
to
Integ-clean_up
MitchellGale
changed the base branch from
Integ-clean_up
to
integ/sl_GoogleJavaFormat3
Yury-Fridlyand
approved these changes
Aug 2, 2023
| * row = comments: { | ||
| * likes: 2 | ||
| * } | ||
| * <p>Sample input: keys = ['comments.likes'] row = comments: { likes: 2 } |
There was a problem hiding this comment.
Thanks! added pre in d52b65c
…re tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/plannercore/src/main/java/org/opensearch/sql/storagecore/src/main/java/org/opensearch/sql/utilsIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.