Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notxt dns #1284

Merged
merged 40 commits into from
Aug 8, 2023
Merged

Notxt dns #1284

merged 40 commits into from
Aug 8, 2023

Conversation

rwincey
Copy link
Contributor

@rwincey rwincey commented Jun 7, 2023

Added advanced option to DNS payload to not use TXT records

  • Added ability to use AAAA DNS records instead of TXT records for comms given the prevalence of defensive signatures on DNS TXT records
  • Added caching table that maps that most recent msgId for a DNS session from the task queue for situations where a custom DNS caching server/resolver is in use that sends multiple identical requests for the same message id in parallel. (Experienced this mid-operation)
  • Added code to send clear messages after a data transfer from the server to ensure replays do not happen in DNS sessions

rwincey added 30 commits May 26, 2023 09:13
@rwincey
Added support for nonTXT based DNS comms
f180dd9
@rwincey
Added AAAA record to response along with CNAME
a8b69b3
@rwincey
Trimmed DNS size to fit within 512
302711e
@rwincey
More size massaging
4c0f36d
@rwincey
More size massaging
e4b6da3
@rwincey
More size massaging
d14003b
@rwincey
More size massaging
683a779
@rwincey
More size massaging
2066d20
@rwincey
Fixed cname recursive lookup
992ee14
@rwincey
Merge branch 'BishopFox:master' into notxt_dns
244639a
@rwincey
Merge branch 'BishopFox:master' into notxt_dns
91b2836
@rwincey
Switched from cname to just aaaa IPs
b8697f6
@rwincey
Merge branch 'notxt_dns' of https://github.com/rwincey/sliver into no…
80e04c7 
…txt_dns
@rwincey
Added error handling, debug msgs, and indexes to AAAA records to be r…
1902f13 
…eassembled
@rwincey
Removed some error handled that was designed that way
ca7b62f
@rwincey
Debug on message send queue
8469c9a
@rwincey
Refuse requests for duplicate requests
58bcac5
@rwincey
Do not respond if there are no messages available
4c84863
@rwincey
Do not respond if there are no messages available
52ff6b4
@rwincey
Attempting to fix race condition in poll
d390ac9
@rwincey
Hopefully fixed race condition
2b2feb3
@rwincey
Initialized new map
f5d2cd2
@rwincey
Hopefully fixed race condition
d341b1c
@rwincey
Hopefully fixed race condition
66b7b98
@rwincey
Fixed empty message bug
76a8de6
@rwincey
Fixed empty message bug
998bd5a
@rwincey
More dbg msgs
4d0f658
@rwincey
Typo
884f2d0
@rwincey
Error msg
185ded6
@rwincey
Don't bail on replay attack
8094742
@rwincey rwincey requested a review from a team as a code owner June 7, 2023 14:21
@moloch-- moloch-- self-assigned this Jun 8, 2023
@rwincey
Copy link
Contributor Author

rwincey commented Jul 28, 2023

Curious what the hold up is on this merge into master?

@rkervella
Copy link
Member

Curious what the hold up is on this merge into master?

Availability to review and test the code. We're busy that's all.

@moloch--
Copy link
Member

moloch-- commented Aug 3, 2023 •
edited
Loading

My apologies @rwincey I was out on vacation for several weeks, and then got covid lol

@moloch-- moloch-- merged commit d048427 into BishopFox:master Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moloch-- moloch-- moloch-- approved these changes

Assignees

@moloch-- moloch--

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwincey @rkervella @moloch--