Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to pdb stream #116

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fix to pdb stream #116

merged 2 commits into from
Mar 27, 2023

Conversation

goniochromatic
Copy link

Description

Fixed the bug where PandasPdb.to_pdb_stream() was returning output.seek(0) instead of output, and the default argument for the records parameter in the same function was changed from a mutable to an immutable object, as general best practice.

Fixed some general typos and style issues in pandas_pdb.py, and also updated the link to "How to contribute" in README.md

Related issues or pull requests

issue #108

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./biopandas/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under biopandas/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./biopandas -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./biopandas/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./biopandas

@a-r-j
Copy link
Contributor

a-r-j commented Mar 26, 2023

LGTM!

@rasbt
Copy link
Member

rasbt commented Mar 27, 2023

Thanks!!

@rasbt rasbt merged commit d0909b9 into BioPandas:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants