Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Poetry #513

Merged
merged 9 commits into from
Sep 10, 2021
Merged

Switch to Poetry #513

merged 9 commits into from
Sep 10, 2021

Conversation

danielgafni
Copy link
Contributor

@danielgafni danielgafni commented Aug 28, 2021

  • Switch to Poetry dependencies manager
  • Add docker image GPU support (FROM nvidia/cuda:11.1-base)
  • Add optional "production" docker build without development dependencies (controllable with the DEPS=[development, production] build arg)
  • Add optional docker build with a fix for nvidia 30xx GPUs (controllable with the NVIDIA_30XX=[true, false] build arg)
  • Local Black pre-commit hook (benefits - fixed black version)
  • CI fixes
  • Required Python version changed 3.6 -> 3.7 (because of scikit-image incompatibility):
The current project's Python requirement (3.6.13) is not compatible with some of the required packages Python requirement:
    - scikit-image requires Python >=3.7, so it will not be satisfied for Python 3.6.13
  
  Because scikit-image (0.18.3) requires Python >=3.7
   and no versions of scikit-image match >0.18.3,<0.19.0, scikit-image is forbidden.
  So, because bindsnet depends on scikit-image (^0.18.3), version solving failed.

@danielgafni
Copy link
Contributor Author

A few python files were changed but that's just Black formatting

@danielgafni
Copy link
Contributor Author

@Hananel-Hazan should I also update CONTRIBUTING.md with poetry related instructions?

@Hananel-Hazan
Copy link
Collaborator

@danielgafni , Please do that

@Hananel-Hazan
Copy link
Collaborator

Thanks @danielgafni for the great work!

@Hananel-Hazan Hananel-Hazan merged commit 37b4c09 into BindsNET:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants