Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview of Page Templates #12

Closed
paaljoachim opened this issue Jul 10, 2019 · 5 comments
Closed

Overview of Page Templates #12

paaljoachim opened this issue Jul 10, 2019 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@paaljoachim
Copy link

Hey

I took a look at the Page Attributes -> Templates and noticed a few.
It would be great if you could add some notes to the readme about each template. Name and what they do. As it would be easier to get an overview of what the theme contains.
Thanks.

@BinaryMoon BinaryMoon self-assigned this Jul 10, 2019
@BinaryMoon
Copy link
Owner

Thanks - that's a good idea and I really appreciate the feedback!

On a slightly related note - what do you think of page templates now that we have Gutenberg? Are they still needed if you can add custom features to any page anyway?

I am wondering about removing some/ all of the page templates as I think their use is less relevant now. But then I am not everyone so I wonder if other people would still find them useful. What do you think?

Thanks

@paaljoachim
Copy link
Author

Hey Ben

Page templates are needed. For now anyway and likely another 6 or so months until Gutenberg has a way to save templates (kinda like saving reusable blocks). In the mean time it would be good to add page templates in the existing fashion so to speak.

If you can write a bit about the page templates you have made then I can also figure out how to test them out and give you feedback directly on those.

BinaryMoon added a commit that referenced this issue Jul 12, 2019
Add descriptions of all templates to readme.txt
Remove guestbook template since it's use is limited (you could use a normal page for the same effect).
Add content only template so we can build totally custom pages with the new editor

#12
@BinaryMoon
Copy link
Owner

BinaryMoon commented Jul 12, 2019

Thanks - that makes sense.

I've updated the readme.txt to include descriptions of the templates, and made a couple of template based changes.

Keep in mind that I haven't tested these templates yet. They probably don't work 100% - I'm still focused on getting the theme design to look right. I'll go through and fix stuff once the theme looks nice :)

@BinaryMoon
Copy link
Owner

Hey @paaljoachim are the changes I made ok or would you like to see something else?

@paaljoachim
Copy link
Author

paaljoachim commented Jul 19, 2019

Hey Ben..:)

Going through the page templates.
Content only.
Shows "A template that removes the site header and footer and displays just the page content." It also removes the background color. This seems ready to be used for a page builder like Beaver Builder or Elementor or other page builders that will control the full page.

Screen Shot 2019-07-19 at 16 58 34

Contributors. Shows the background color selected through the customizer.
Looks totally fine. Might be useful.

Screen Shot 2019-07-19 at 17 00 27

Child Page Grid. Kinda shows sub pages like a blog page shows blog posts.
Looks ok. Might be useful.

Screen Shot 2019-07-19 at 16 59 40

Portfolio. Not checked.

I would just leave all of them in as they are (for now anyway).
I am seeing a huge space between the header and the page title.

@BinaryMoon BinaryMoon changed the title Overview of Page Templates (Documentation) Overview of Page Templates Jul 19, 2019
@BinaryMoon BinaryMoon added the documentation Improvements or additions to documentation label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants