Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate capybara driver to cuprite #204

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Irving-Betterment
Copy link
Contributor

@Irving-Betterment Irving-Betterment commented Nov 9, 2023

Summary

  • Replace selenium-webdriver with cuprite.
  • Upgrade primer_view_components up to a version that fixes JS errors detected in system tests.
  • Remove chromedriver from ci.yml (no needed anymore!).

/task https://app.asana.com/0/1205654148374805/1205654148376945/f
/domain @Betterment/test_track_core

@@ -282,10 +291,10 @@ GEM
parser (3.2.1.0)
ast (~> 2.4.1)
pg (1.4.5)
primer_view_components (0.1.0)
primer_view_components (0.1.9)
Copy link
Contributor Author

@Irving-Betterment Irving-Betterment Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated version to fix JS error due

Ferrum::JavaScriptError:
    DOMException: Failed to execute ‘define’ on ‘CustomElementRegistry’: “ce” is not a valid custom element name
      at [http://127.0.0.1:50557/assets/primer_view_components](http://127.0.0.1:50557/assets/primer_view_components-e90dd7a3559738d8ed171ca4865f2733f09aa51abd373cb85e4876be79c333b4.js:2:6760)

Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM

@smudge smudge merged commit 2d52bf3 into Betterment:main Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants