Expand split representation

Betterment · Jun 7, 2018 · a2145bd · a2145bd
1 parent 2e63f86
commit a2145bd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/app/views/api/v2/split_registries/show.json.jbuilder b/app/views/api/v2/split_registries/show.json.jbuilder
@@ -1,6 +1,9 @@
 json.splits do
   @split_registry.splits.each do |split|
-    json.set! split.name, split.registry
+    json.set! split.name do
+      json.weights split.registry
+      json.feature_gate split.feature_gate?
+    end
   end
   json.merge!({})
 end

diff --git a/spec/controllers/api/v2/split_registries_controller_spec.rb b/spec/controllers/api/v2/split_registries_controller_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe Api::V2::SplitRegistriesController, type: :controller do
   let(:split_1) { FactoryBot.create :split, name: "one", finished_at: Time.zone.now, registry: { all: 100 } }
   let(:split_2) { FactoryBot.create :split, name: "two", registry: { on: 50, off: 50 } }
-  let(:split_3) { FactoryBot.create :split, name: "three", registry: { true: 99, false: 1 } }
+  let(:split_3) { FactoryBot.create :split, name: "three_enabled", registry: { true: 99, false: 1 }, feature_gate: true }
 
   describe "#show" do
     before do
@@ -31,8 +31,14 @@
 
       expect(response).to have_http_status :ok
       expect(response_json['splits']).to eq(
-        "two" => { "on" => 50, "off" => 50 },
-        "three" => { "true" => 99, "false" => 1 }
+        "two" => {
+          "weights" => { "on" => 50, "off" => 50 },
+          "feature_gate" => false
+        },
+        "three_enabled" => {
+          "weights" => { "true" => 99, "false" => 1 },
+          "feature_gate" => true
+        }
       )
     end
   end