Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deserialising and then serialising a statement the objectType the value should be retained #200

Merged
merged 16 commits into from
Aug 8, 2023

Conversation

thomasturrell
Copy link
Contributor

@thomasturrell thomasturrell commented Aug 7, 2023

Description

Resolves #201

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

Selindek
Selindek previously approved these changes Aug 8, 2023
Thomas Turrell-Croft added 2 commits August 8, 2023 11:50
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thomasturrell thomasturrell changed the title Add tests for objectType in activity When deserialising and then serialising a statement the objectType the value should be retained Aug 8, 2023
@thomasturrell thomasturrell merged commit 8e58ff6 into main Aug 8, 2023
5 checks passed
@thomasturrell thomasturrell deleted the fix-objecttype-should-be-a-property branch August 8, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: When deserialising and then serialising a statement the objectType the value should be retained
2 participants