Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add voidStatement and getStatementIterator to xApiEnhancedClient #144

Merged
merged 11 commits into from
Apr 24, 2023
Merged

add voidStatement and getStatementIterator to xApiEnhancedClient #144

merged 11 commits into from
Apr 24, 2023

Conversation

Selindek
Copy link
Contributor

No description provided.

thomasturrell
thomasturrell reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@thomasturrell thomasturrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we auto configure the enhanced client?

thomasturrell
thomasturrell reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@thomasturrell thomasturrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add samples and documentation

@Selindek
stuffz
d7d0bd3 
- add sample
- add documentation
- move features to xapiClient
- add toStream() method to StatementIterator
- add test for stream
@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thomasturrell thomasturrell merged commit f311bed into main Apr 24, 2023
@thomasturrell thomasturrell deleted the Add_enhanced_client branch April 24, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasturrell thomasturrell thomasturrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Selindek @thomasturrell