Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model autoconfigure #110

Merged
merged 29 commits into from
Apr 4, 2023
Merged

Add model autoconfigure #110

merged 29 commits into from
Apr 4, 2023

Conversation

Selindek
Copy link
Contributor

@Selindek Selindek commented Apr 3, 2023 •
edited by thomasturrell
Loading

Description

Resolves # (issue)

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

thomasturrell
thomasturrell reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@thomasturrell thomasturrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check all files:

  • for use of xAPI. It should be xAPI in text and Xapi in class names.
  • that the Copyright message is the same (lots of errors in dates)

thomasturrell
thomasturrell reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@thomasturrell thomasturrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run mvn javadoc:javadoc and fix any problems that you find.

Base automatically changed from polish-xapi-server-sample to main April 3, 2023 21:57
thomasturrell
thomasturrell reviewed Apr 3, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@thomasturrell thomasturrell changed the title Polish polish Add model autoconfigure Apr 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.0% 63.0% Coverage
0.0% 0.0% Duplication

@thomasturrell thomasturrell merged commit 1eda3c5 into main Apr 4, 2023
@thomasturrell thomasturrell deleted the polish-polish branch April 5, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasturrell thomasturrell thomasturrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Selindek @thomasturrell