Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meetup): add Meetup Rust Lyon #419

Merged
merged 2 commits into from
Apr 25, 2023
Merged

feat(meetup): add Meetup Rust Lyon #419

merged 2 commits into from
Apr 25, 2023

Conversation

Oliboy50
Copy link
Member

@Oliboy50 Oliboy50 commented Apr 23, 2023 •
edited
Loading

Visible changes

  • add "Meetup Rust Lyon" event
  • fix showing the "13/05: Docker meetup" event as "hosted" and "sponsored" by Bedrock
    • only 1 of the 2 talks were marked as "hosted"/"sponsored" so it was not showing

Invisible changes

  • fix Dockerfile base image (liquid 4.x does not support ruby 3.2 so this PR pins the ruby version used to 3.1)
  • removed an unused "c_chaplin.png" avatar file ("c_chaplin.jpg" is still used)
  • fix typos in CONTRIBUTING + document "sponsored" and "hosted" parameters

@aws-amplify-eu-west-3
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-419.dsvmt7xpjktgx.amplifyapp.com

@Oliboy50 Oliboy50 self-assigned this Apr 23, 2023
TimotheCrespy
TimotheCrespy reviewed Apr 24, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
_data/authors.yml Show resolved Hide resolved
TimotheCrespy
TimotheCrespy approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@TimotheCrespy TimotheCrespy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce normal de n'avoir aucun résultat en rapport avec tes ajouts pour la recherche "rust" ?

@Oliboy50 Oliboy50 merged commit 3681e9e into master Apr 25, 2023
@Oliboy50 Oliboy50 deleted the meetup-rust-lyon-3 branch April 25, 2023 11:44
@Oliboy50
Copy link
Member Author

Est-ce normal de n'avoir aucun résultat en rapport avec tes ajouts pour la recherche "rust" ?

vu ensemble en direct
=> IMO c'est OK que la page de "Meetup and conferences" ne ressortent pas dans la recherche du blog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shavounet shavounet shavounet approved these changes

@TimotheCrespy TimotheCrespy TimotheCrespy approved these changes

Assignees

@Oliboy50 Oliboy50

Labels
Ready for Review Size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oliboy50 @shavounet @TimotheCrespy