Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove trailing_comma_in_multiline because it's not work with PHP 7.4 #28

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: remove trailing_comma_in_multiline because it's not work with PHP 7.4 #28

merged 2 commits into from
Aug 21, 2024

Conversation

antten
Copy link
Contributor

@antten antten commented Aug 21, 2024 •
edited
Loading

Why?

PHP 7.4 does not support comma on last entry for method parameters and match

TODO

  • code is tested
  • documentation is updated (if needed)

@antten antten marked this pull request as ready for review August 21, 2024 09:55
@antten antten requested a review from a team as a code owner August 21, 2024 09:55
@Benoit382 Benoit382 merged commit b49461d into BedrockStreaming:master Aug 21, 2024
3 checks passed
@antten antten deleted the fix/remove_trailing_comma_in_multiline branch August 21, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-zannelli e-zannelli e-zannelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antten @e-zannelli @Benoit382