Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): update friendsofphp/php-cs-fixer #26

Merged
merged 2 commits into from
May 22, 2024
Merged

feat(deps): update friendsofphp/php-cs-fixer #26

merged 2 commits into from
May 22, 2024

Conversation

nalscher
Copy link
Contributor

@nalscher nalscher commented May 20, 2024 •
edited
Loading

Why?

Update dependencies and remove old config

@nalscher nalscher marked this pull request as ready for review May 20, 2024 17:53
@nalscher nalscher requested a review from a team as a code owner May 20, 2024 17:53
@nalscher
Copy link
Contributor Author

@Oliboy50 @burahimu What do you think, do we have to create a major (because of removing < php74) or a minor ?

@Oliboy50
Copy link
Member

seems like a breaking change to me, so I would say "major"

@nalscher nalscher merged commit 8ffa630 into master May 22, 2024
3 checks passed
@nalscher nalscher deleted the feat/update-friendsofphp/php-cs-fixer branch May 22, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oliboy50 Oliboy50 Oliboy50 approved these changes

@burahimu burahimu burahimu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nalscher @Oliboy50 @burahimu