add rule 'declare_strict_types' => true #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloFrad
approved these changes
Apr 21, 2022
Siwayll
approved these changes
Apr 21, 2022
Oliboy50
approved these changes
Apr 21, 2022
|
@valentin-claras he did not change the other configs, he only added "declare(strict_types=1)" to these files (maybe because he simply ran it looks good |
That's exactly what I did, but I understand there's no real point in updating deprecated files indeed ... 🤷🏼 |
sztan
force-pushed
the
feat/add-declare_strict_types-rule
branch
from
56ff3db
to
e254b0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this rule via cs-fixer following a common decision (internal RFC).
This will prevent some oversights and help us to use php strict typing.