Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub OAuth #19

Closed
wants to merge 4 commits into from
Closed

GitHub OAuth #19

wants to merge 4 commits into from

Conversation

AntoineReneleau
Copy link
Contributor

kennydee
kennydee reviewed Jun 25, 2015
View reviewed changes
app/scripts/controllers/auth.js
localStorage.oauthAccessToken = accessToken;
$window.location.href = '/';
}, function(reason) {
console.log('fail', reason);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y'a peut être meux à faire que du console.log ?

@fdubost
Copy link
Member

fdubost commented Jun 25, 2015

@AntoineReneleau tu penses que certaines parties sont testables ?

@AntoineReneleau
Copy link
Contributor Author

Je vais déjà faire les corrections, mettre en place l'OAuth multiapp et je me mettrai sur les tests après. 😄

fdubost
fdubost reviewed Jun 30, 2015
View reviewed changes
app/scripts/services/authManager.js
},

getLogoutClientIds: function() {
var accessTokens = this.getAccessTokens();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Espace en trop avant le = 😉

@fdubost
Copy link
Member

fdubost commented Sep 14, 2015

Left for #20

@fdubost fdubost closed this Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntoineReneleau @fdubost @kennydee