Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Deprecated API usage #911

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

muhib349
Copy link
Contributor

@muhib349 muhib349 commented Dec 31, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Removed deprecated method webOnlyInstantiateImageCodecFromUrl, used createImageCodecFromUrl

⤵️ What is the current behavior?

Warning, about to remove webOnlyInstantiateImageCodecFromUrl method

🆕 What is the new behavior (if this is a feature change)?

Replaced with createImageCodecFromUrl

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Yes

📝 Links to relevant issues/docs

#906

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@erdzan12
Copy link

erdzan12 commented Feb 2, 2024

Are there any further points which need to be clarified to merge this?

@amrgetment
Copy link

@erdzan12 I am not a repo contributor but I can approve only 😂

@muhib349
Copy link
Contributor Author

muhib349 commented Feb 2, 2024

Are there any further points which need to be clarified to merge this?

No, that's the only thing.

@ReinisSprogis
Copy link

Would be nice to see this progressing. Any way I can help?

@ReinisSprogis
Copy link

Are there any further points which need to be clarified to merge this?

No, that's the only thing.

Any idea why this is not progressing?

@amrgetment
Copy link

@renefloor Could you check this PR? Thanks

@MyBlueford16
Copy link

any update on this?

@nc-jeni
Copy link

nc-jeni commented Mar 13, 2024

+1

When will this be merged and released in a new version?
@amorenew @amrgetment @renefloor

@c-seeger
Copy link

c-seeger commented Apr 8, 2024

@renefloor @amorenew any chance this project gets some love?

@jbwise
Copy link

jbwise commented Apr 23, 2024

This fix being applied would be wonderful. It eliminates an enormous number of errors in image-heavy flutter web sites.

@ReinisSprogis
Copy link

Package is abandoned.

@amrgetment
Copy link

@amorenew @amrgetment is not a maintainer I just tried to approve but as both accounts are not a collaborator then it won’t affect the PR

@chief-nerd
Copy link

We need this merged ... fix is simple and no risk. Needs to go in!

@c-seeger
Copy link

@BeMacized or @martijn00 since this repository is part of Baseflow, can you help out here?

@chief-nerd
Copy link

chief-nerd commented Apr 29, 2024

Ok awesome -- we have 2 reviews here! --- Now we "just" need to press the "Merge" button and make a release .... Anyone?

@amrgetment
Copy link

@mvanbeusekom we need a review and merge for this PR

@ReinisSprogis

This comment was marked as off-topic.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvanbeusekom mvanbeusekom merged commit 9f3cd25 into Baseflow:develop Apr 29, 2024
3 checks passed
@nc-jeni
Copy link

nc-jeni commented May 1, 2024

LGTM!

Please tell, which stable release version that will have this fix included?
I am not interested in a develop version pulled directly into production code.
@mvanbeusekom

@mvanbeusekom
Copy link
Member

It has been released in version 1.2.0 of the cached_network_image_web package.

This as a dependency of the cached_network_image, so running flutter pub upgrade should automatically download the new version.

@c-seeger
Copy link

c-seeger commented May 1, 2024

@mvanbeusekom this looks wrong to me since the current version released is v3.3.1 which is from december 31, 2023.

I guess the correct tag version would be
v3.3.2

Also the v1.2.0 tag is named chached_network_image_web_v1.2.0 which is not a valid semversion

@mvanbeusekom
Copy link
Member

mvanbeusekom commented May 1, 2024

Hi @c-seeger,

The cached_network_image package (current version 3.3.1) internally relies on the cached_network_image_web package (current version 1.2.0) to provide support for the web platform.

If you check the pubspec.yaml of the cached_network_image package you'll see the following dependency:

dependencies:
  ...
  cached_network_image_web: ^1.1.1

The ^ syntax here is a version constraint meaning: "depend on the latest version of cached_network_image_web larger or equal to 1.1.1 but smaller then 2.0.0. This means that version 1.2.0 of the cached_network_image_web will automatically be used if you update your dependencies. More details on dependencies and version constraints can be found in the Dart documentation: https://dart.dev/tools/pub/dependencies#version-constraints.

Regarding the tag, this is just a tag and since the repository contains multiple packages we need to differentiate between which version of which package is updated, hence the name of the package in front of the version number in the tag name. If you want to know more of how this works exactly read up on the Federated architecture on the Flutter documentation.

@c-seeger
Copy link

c-seeger commented May 1, 2024

Hi @c-seeger,

The cached_network_image package (current version 3.3.1) internally relies on the cached_network_image_web package (current version 1.2.0) to provide support for the web platform.

If you check the pubspec.yaml of the cached_network_image package you'll see the following dependency:

dependencies:
  ...
  cached_network_image_web: ^1.1.1

The ^ syntax here is a version constraint meaning: "depend on the latest version of cached_network_image_web larger or equal to 1.1.1 but smaller then 2.0.0. This means that version 1.2.0 of the cached_network_image_web will automatically be used if you update your dependencies. More details on dependencies and version constraints can be found in the Dart documentation: https://dart.dev/tools/pub/dependencies#version-constraints.

Regarding the tag, this is just a tag and since the repository contains multiple packages we need to differentiate between which version of which package is updated, hence the name of the package in front of the version number in the tag name. If you want to know more of how this works exactly read up on the Federated architecture on the Flutter documentation.

Awesome thank you for clarifying this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet