Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate error reporting #910

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

renefloor
Copy link
Collaborator

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix on new feature

⤵️ What is the current behavior?

After PR #891 was merged we got a duplicate error reporting. The same error is reported twice.
With reporting through the ImageStreamCompleter we should remove the extra reporting in the image loaders.

This also updates the changelogs and versions

🆕 What is the new behavior (if this is a feature change)?

Only report errors once.

💥 Does this PR introduce a breaking change?

no

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d3434a) 79.48% compared to head (83a63d7) 79.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #910      +/-   ##
===========================================
+ Coverage    79.48%   79.91%   +0.42%     
===========================================
  Files            4        5       +1     
  Lines          234      234              
===========================================
+ Hits           186      187       +1     
+ Misses          48       47       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renefloor renefloor merged commit f7e9672 into develop Dec 31, 2023
15 of 17 checks passed
@martijn00 martijn00 deleted the feature/remove-duplicate-error-reporting branch July 31, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant