Skip to content

Commit

Permalink
Merge pull request #891 from RWolfing/develop
Browse files Browse the repository at this point in the history
Add missing error listener to MultiImageStreamCompleter
  • Loading branch information
renefloor committed Dec 31, 2023
2 parents 7f49efc + 32e2c08 commit 7d3434a
Showing 1 changed file with 28 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class CachedNetworkImageProvider
DecoderBufferCallback decode,
) {
final chunkEvents = StreamController<ImageChunkEvent>();
return MultiImageStreamCompleter(
final imageStreamCompleter = MultiImageStreamCompleter(
codec: _loadBufferAsync(key, chunkEvents, decode),
chunkEvents: chunkEvents.stream,
scale: key.scale,
Expand All @@ -86,6 +86,19 @@ class CachedNetworkImageProvider
);
},
);

if (errorListener != null) {
imageStreamCompleter.addListener(
ImageStreamListener(
(image, synchronousCall) {},
onError: (Object error, StackTrace? trace) {
errorListener?.call(error);
},
),
);
}

return imageStreamCompleter;
}

@Deprecated('_loadBufferAsync is deprecated, use _loadImageAsync instead')
Expand Down Expand Up @@ -116,7 +129,7 @@ class CachedNetworkImageProvider
ImageDecoderCallback decode,
) {
final chunkEvents = StreamController<ImageChunkEvent>();
return MultiImageStreamCompleter(
final imageStreamCompleter = MultiImageStreamCompleter(
codec: _loadImageAsync(key, chunkEvents, decode),
chunkEvents: chunkEvents.stream,
scale: key.scale,
Expand All @@ -128,6 +141,19 @@ class CachedNetworkImageProvider
);
},
);

if (errorListener != null) {
imageStreamCompleter.addListener(
ImageStreamListener(
(image, synchronousCall) {},
onError: (Object error, StackTrace? trace) {
errorListener?.call(error);
},
),
);
}

return imageStreamCompleter;
}

Stream<ui.Codec> _loadImageAsync(
Expand Down

0 comments on commit 7d3434a

Please sign in to comment.