Upgrade to Dart 3 to compatibility with http ^1.0.0 #414

Carapacik · 2023-05-24T07:30:19Z

Update dependencies
Update example to latest version
Fix analysis and format issues

Also update cached_network_image PR

All projects build
Follows style guide lines (code style guide)
Relevant documentation was updated
Rebased onto current develop

Carapacik · 2023-05-24T11:40:52Z

#413

Sreeharikr · 2023-05-29T09:19:50Z

Yeah.... I can't upgrade http package and packages depending on http.

renefloor

Hi thanks for the nice PR. Also thanks for the cleanup throughout the code. However, this makes it a bit harder for me to spot the really important differences.

As far as I can see http 1.0.0 has no breaking changes, besides using new Dart 3.0 language features. So I think we can allow for http 1.0.0 without dropping support for 0.13.0 right? That makes it easier for others to upgrade in their own time.

I see you also dropped support for rxdart 0.26.0. Is there any reason for it? That version already is made with null safety looking at pub.dev. With a package it's always important to support as big of a range of versions as possible.

flutter_cache_manager/pubspec.yaml

Carapacik · 2023-06-19T19:34:42Z

I agree with rxdart, and upgraded the rest to support null safety.

Carapacik · 2023-06-19T19:39:16Z

Also check my PR for cached_network_image please

flutter_cache_manager/example/pubspec.yaml

flutter_cache_manager/pubspec.yaml

flutter_cache_manager/example/lib/plugin_example/download_page.dart

flutter_cache_manager/CHANGELOG.md

flutter_cache_manager/pubspec.yaml

codecov · 2023-06-19T19:54:28Z

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.22 ⚠️

Comparison is base (28e081e) 75.39% compared to head (06dbb27) 75.18%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #414      +/-   ##
===========================================
- Coverage    75.39%   75.18%   -0.22%     
===========================================
  Files           22       22              
  Lines          691      685       -6     
===========================================
- Hits           521      515       -6     
  Misses         170      170

Impacted Files	Coverage Δ
.../lib/src/cache_managers/default_cache_manager.dart	`0.00% <ø> (ø)`
...utter_cache_manager/lib/src/config/_config_io.dart	`12.50% <ø> (ø)`
flutter_cache_manager/lib/src/logger.dart	`75.00% <ø> (-5.00%)`	⬇️
...cache_info_repositories/cache_object_provider.dart	`0.00% <0.00%> (ø)`
...torage/cache_info_repositories/helper_methods.dart	`100.00% <ø> (ø)`
...info_repositories/non_storing_object_provider.dart	`0.00% <0.00%> (ø)`
...er/lib/src/storage/file_system/file_system_io.dart	`0.00% <0.00%> (ø)`
..._info_repositories/json_cache_info_repository.dart	`90.62% <94.44%> (ø)`
flutter_cache_manager/lib/src/cache_manager.dart	`88.15% <100.00%> (-0.16%)`	⬇️
...er/lib/src/cache_managers/image_cache_manager.dart	`100.00% <100.00%> (ø)`
... and 7 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Carapacik · 2023-06-19T20:28:07Z

Analyzer and format issues fixed

ryanheise · 2023-06-21T13:16:01Z

Hi thanks for the nice PR. Also thanks for the cleanup throughout the code. However, this makes it a bit harder for me to spot the really important differences.

It might be helpful to update CONTRIBUTING.md with guidelines to keep the diffs minimal in a pull request to aid the review process, and to avoid addressing multiple unrelated issues in a single pull request. I can see how reviewing 110 changed files for a PR that upgrades a dependency could be somewhat uncomfortable.

Carapacik · 2023-07-01T13:03:09Z

@renefloor, Is it worth updating build_runner min version to 2.0.0? Since previous versions support Dart < 2.12. build_runner is still only needed to generate for mockito.

flutter_cache_manager/example/pubspec.yaml

renefloor · 2023-07-03T06:29:19Z

I'm testing the code now on the oldest and newest Flutter versions, hope you don't mind pushing some fixes directly?

Carapacik · 2023-07-03T06:33:47Z

I'm testing the code now on the oldest and newest Flutter versions, hope you don't mind pushing some fixes directly?

No problem

Carapacik · 2023-07-03T06:57:24Z

@renefloor Do you mind if I make some changes to delete unused rows in example to pass analysis?

renefloor · 2023-07-03T07:05:37Z

I'm currently also still making some changes, so maybe better to wait and not create (many) merge conflicts.

It's too hard to keep the current minimum. I would have to allow flutter_lints 1.0.4, but that means that various developers can have different set of warnings. Setting the minimum to Dart 2.17.0 and Flutter 3.0.0, which are both over 1 year old.

Carapacik · 2023-07-03T07:08:06Z

I'm currently also still making some changes, so maybe better to wait and not create (many) merge conflicts.

It's too hard to keep the current minimum. I would have to allow flutter_lints 1.0.4, but that means that various developers can have different set of warnings. Setting the minimum to Dart 2.17.0 and Flutter 3.0.0, which are both over 1 year old.

flutter_lines and other dev_dependencies dependencies do not affect the operation of package versions. That is, if dev_dependencies has the minimum version 2.17, and dependencies 2.12, then the package will have version 2.12.

Carapacik · 2023-07-03T07:10:47Z

If anything, I would recommend putting a minimum 2.19 version of dart for the package. Since it is the last one that supports no-sound-null-safety.

renefloor · 2023-07-03T07:18:42Z

That is, if dev_dependencies has the minimum version 2.17, and dependencies 2.12, then the package will have version 2.12.

I expect so as well, but it did complain if I try to add it as a dependency in another clean project.

renefloor · 2023-07-03T07:23:53Z

@Carapacik it looks good to me now, you agree?
I'm ignoring the code coverage now.

Carapacik · 2023-07-03T07:24:51Z

Now yes

renefloor · 2023-07-03T07:29:19Z

I wonder if anybody will ever run this as real compiled app 😆

Carapacik · 2023-07-03T07:31:08Z

of course it will compile

renefloor · 2023-07-03T07:31:51Z

I meant for this change in the example:

      if (kDebugMode) {
        print(error);
      }

Carapacik · 2023-07-03T07:31:51Z

@renefloor cached_network_image next?

renefloor · 2023-07-03T07:34:47Z

cached_network_image next?

I now have to start really working, but probably can look at it tomorrow.

I think it should work fine already though.
flutter_cache_manager: ^3.3.0 should automatically resolve to 3.3.1 and I don't see any other conflicting dependencies. Only the sdk should be <4.0.0, but I believe that is basically ignored for Dart 3.0.0?

Carapacik · 2023-07-03T07:36:23Z

cached_network_image next?

I now have to start really working, but probably can look at it tomorrow.

I think it should work fine already though. flutter_cache_manager: ^3.3.0 should automatically resolve to 3.3.1 and I don't see any other conflicting dependencies. Only the sdk should be <4.0.0, but I believe that is basically ignored for Dart 3.0.0?

There is still file ^7.0.0 used and there is an error with types somewhere.
Also in that PR, the example has been updated.

renefloor · 2023-07-03T07:44:52Z

@Carapacik published flutter_cache_manager: https://pub.dev/packages/flutter_cache_manager/versions/3.3.1

Carapacik added 2 commits May 24, 2023 10:29

Upgrade to Dart 3

92e268e

Update build_runner and mockito to support latest version

18e731d

MagnusJohansson mentioned this pull request May 28, 2023

Please consider upgrade the dependencies to the latest Dart 3 / File 7.0 #417

Closed

Add changelog

3c17344

robson-rp approved these changes Jun 1, 2023

View reviewed changes

Carapacik added 2 commits June 2, 2023 16:09

Format code

8cf0557

Update path_provider to support newest xdg_directories

d1dbbe6

PcolBP approved these changes Jun 5, 2023

View reviewed changes

Update example for latest baseflow_plugin_template

dd0821e

renefloor reviewed Jun 19, 2023

View reviewed changes

flutter_cache_manager/pubspec.yaml Outdated Show resolved Hide resolved

Carapacik added 2 commits June 19, 2023 22:31

http >=0.13.0 <2.0.0

6819fbc

rxdart dependency

7cce7e2

Fix rxdart dependency

2624abc

renefloor reviewed Jun 19, 2023

View reviewed changes

Carapacik added 3 commits June 19, 2023 22:55

Fix for PR

9d97fd0

Remove unawaited to support dart 2.12

0d994b2

Fixes for analyzer

cdce65f

Update example

3e6a6bb

Carapacik requested a review from renefloor June 20, 2023 14:06

Carapacik added 2 commits June 20, 2023 17:50

Downgrade collection lower bound and support for uuid 4.0.0

088a3e0

Add type annotations

9f84b5b

ryanheise mentioned this pull request Jun 21, 2023

Version solving faliled with flutter_cache_manager and http ryanheise/audio_service#1028

Open

clock back to 1.1.0 for support dart 2.12

8f5e260

Carapacik added 2 commits July 1, 2023 14:42

Add topics

bfa3202

Format tests and update build_runner to ^2.0.0

f40e897

Carapacik mentioned this pull request Jun 30, 2023

Fix analyzer issues and update example for Dart 3 Baseflow/flutter_cached_network_image#845

Closed

4 tasks

Carapacik added 2 commits July 2, 2023 14:57

Fix android build with github actions

8f31ea2

Fix link in example assets

cf35001

renefloor reviewed Jul 3, 2023

View reviewed changes

flutter_cache_manager/example/pubspec.yaml Outdated Show resolved Hide resolved

renefloor added 2 commits July 3, 2023 08:22

Remove unused assets

32051dc

remove empty assets list

c8a087a

renefloor and others added 2 commits July 3, 2023 08:34

Fix null reference bug

7d34e34

Remove unused assets

0c73ad3

Update minimal dart sdk version

07174f6

Update example

06dbb27

renefloor merged commit 7fbc493 into Baseflow:develop Jul 3, 2023
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Dart 3 to compatibility with http ^1.0.0 #414

Upgrade to Dart 3 to compatibility with http ^1.0.0 #414

Carapacik commented May 24, 2023 •

edited

Loading

Carapacik commented May 24, 2023

Sreeharikr commented May 29, 2023

renefloor left a comment

Carapacik commented Jun 19, 2023

Carapacik commented Jun 19, 2023 •

edited

Loading

codecov bot commented Jun 19, 2023 •

edited

Loading

Carapacik commented Jun 19, 2023

ryanheise commented Jun 21, 2023

Carapacik commented Jul 1, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

renefloor commented Jul 3, 2023 •

edited

Loading

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023 •

edited

Loading

renefloor commented Jul 3, 2023

Upgrade to Dart 3 to compatibility with http ^1.0.0 #414

Upgrade to Dart 3 to compatibility with http ^1.0.0 #414

Conversation

Carapacik commented May 24, 2023 • edited Loading

Carapacik commented May 24, 2023

Sreeharikr commented May 29, 2023

renefloor left a comment

Choose a reason for hiding this comment

Carapacik commented Jun 19, 2023

Carapacik commented Jun 19, 2023 • edited Loading

codecov bot commented Jun 19, 2023 • edited Loading

Codecov Report

Carapacik commented Jun 19, 2023

ryanheise commented Jun 21, 2023

Carapacik commented Jul 1, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

renefloor commented Jul 3, 2023 • edited Loading

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023

renefloor commented Jul 3, 2023

Carapacik commented Jul 3, 2023 • edited Loading

renefloor commented Jul 3, 2023

Carapacik commented May 24, 2023 •

edited

Loading

Carapacik commented Jun 19, 2023 •

edited

Loading

codecov bot commented Jun 19, 2023 •

edited

Loading

renefloor commented Jul 3, 2023 •

edited

Loading

Carapacik commented Jul 3, 2023 •

edited

Loading