Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to handle file extension with content-type that has defined charset #164

Closed
xilibro opened this issue Apr 13, 2020 · 2 comments · Fixed by #165
Closed

Is it possible to handle file extension with content-type that has defined charset #164

xilibro opened this issue Apr 13, 2020 · 2 comments · Fixed by #165

Comments

@xilibro
Copy link

xilibro commented Apr 13, 2020

🚀 Feature Requests

My file server return file with content-type as flowing:
content-type: application/pdf;chartset=UTF-8

Can you consider this case when handle file extension?
@renefloor
Copy link
Collaborator

Yes of course, I thought it already did. Will fix it quickly

renefloor added a commit that referenced this issue Apr 14, 2020
@renefloor
Don't compare with full content-type, but with mimetype
858c476 
Fixes #164
@renefloor renefloor mentioned this issue Apr 14, 2020
Merged
4 tasks
@renefloor
Copy link
Collaborator

@xilibro fixed in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't compare with full content-type, but with mimetype Baseflow/flutter_cache_manager
2 participants
@xilibro @renefloor