Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster ViewPager swiping; Improved logging; Fix: loading huge images; fix memory leak; added media-db-cursor sample-demo #372

Closed
wants to merge 17 commits into from

Conversation

k3b
Copy link

@k3b k3b commented Jun 13, 2016

This is a Backport of PhotoView improvements from https://github.com/k3b/APhotoManager

  • Faster initial loading so swiping through ViewPager is more fluent:
  • Fix: No crash when loading images bigger than 4096x4096 or out of memory
  • Improved logging
    • possibility to reduce logging: either logg all or info+warn+err or warn+err
      • via LogManager.setLogger() and LogManager.enableDebug()
    • many internal functions get a string parameter why so logging shows why a function was called
  • fixed memory leak
  • added media-db sample-demo for faster swiping
  • Note: a few local debug properties were made public
    • public static final String LOG_TAG = ... to allow crashreport filtering via adb
    • public static boolean DEBUG = true; so customer settings-activity can change this (and the details of the crashlog)

Jawnnypoo and others added 17 commits May 5, 2016 00:21
Remove redundant variable which is always false
Make getOnViewTapListener() and getOnPhotoTapListener() package local
… fix memory leak

This is a Backport of PhotoView improvements from  https://github.com/k3b/APhotoManager

* Faster initial loading so swiping through ViewPager is more fluent:
  * initially the view is loaded with low res image. (defined via PhotoView.setImageXxx)
  * on first zoom it is reloaded (defined via PhotoView.setImageReloadFile())
  * see k3b/APhotoManager#10 Fast swiping through images does not work
* Fix: No crash when loading images bigger than 4096x4096 or out of memory
  * HugeImageLoader.java
  * see k3b/APhotoManager#15
* Improved logging
  * possibility to reduce logging: either logg all or info+warn+err or warn+err
    * via LogManager.setLogger() and LogManager.enableDebug()
  * many internal functions get a string parameter `why` so logging shows why a function was called
* fix memory leak
…e these in the settings dialog and to allow filtering crash reports
@k3b
Copy link
Author

k3b commented Jun 13, 2016

sorry i selected the wrong branches

@k3b k3b closed this Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants