Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): introduce Nuxt Scripts as alternative to useScript #485

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

vejja
Copy link
Collaborator

@vejja vejja commented Jul 1, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

This PR is only a doc change on how to load 3rd-party scripts.
Instead of useScript, we recommend using the Nuxt Scripts module

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 10:38pm

@vejja
Copy link
Collaborator Author

vejja commented Jul 1, 2024

@harlan-zw I'm updating our docs to stop recommending importing useScript directly from 'unjs/unhead', and instead recommend using the Nuxt Scripts module. Would you agree with this change or is there something we should consider here ?

@harlan-zw
Copy link

Yes good to go, thanks for asking.

@Baroshem
Copy link
Owner

Thanks @harlan-zw !

@vejja would you like to merge the PR now? :)

@Baroshem Baroshem changed the base branch from main to chore/2.0.0 July 16, 2024 06:40
@Baroshem Baroshem marked this pull request as ready for review July 16, 2024 06:40
@Baroshem Baroshem merged commit 2d0ae0a into chore/2.0.0 Jul 16, 2024
5 checks passed
@Baroshem Baroshem mentioned this pull request Jul 16, 2024
6 tasks
@Baroshem
Copy link
Owner

Released in 2.0.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants