Disable 05-cspSsgPresets #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Some tests are not passing and was wondering if it is caused by the removing of the module or can we skip it? |
Sorry I was too quick in hitting create |
|
Ok thanks for that @vejja ! I am off right now but will release a patch version in the evening with your change. |
Baroshem
approved these changes
Jan 17, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #348
Fixes #335
Types of changes
Description
This patch removes the cspSsgPresets functionality to temporarily solve issues #335 and #348, while we work on an alternative solution.
This patch is required after Nuxt 3.9.3 introduced protection against importing
@nuxt/kitin Nitro plugins, which breaks05-cspSsgPresets.tsin our module.Checklist: